Skip to content

add support for custom properties on sessions#151

Merged
brookfxg merged 5 commits into
mainfrom
brook/dc-666-add-support-for-session-custom-properties-to-foxglove-python
Mar 12, 2026
Merged

add support for custom properties on sessions#151
brookfxg merged 5 commits into
mainfrom
brook/dc-666-add-support-for-session-custom-properties-to-foxglove-python

Conversation

@brookfxg

@brookfxg brookfxg commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Changelog

  • Add support for custom property add / edit on sessions.
  • Fixes an error when retrieving sessions that have no key set.

Docs

None

Description

This is in line with other methods that support custom properties (devices, events)

@linear

linear Bot commented Mar 11, 2026

Copy link
Copy Markdown

Comment thread foxglove/client/api.py
"project_id": session["projectId"],
"device": session["device"],
"key": session["key"],
"key": session.get("key"),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated bug fix. Old referential lookup was failing if the session has no key.

@brookfxg brookfxg self-assigned this Mar 11, 2026
claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

brookfxg and others added 3 commits March 12, 2026 09:55
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…to-foxglove-python' of github.com:foxglove/foxglove-python into brook/dc-666-add-support-for-session-custom-properties-to-foxglove-python
@brookfxg brookfxg marked this pull request as ready for review March 12, 2026 17:03
@brookfxg brookfxg requested a review from mguida22 as a code owner March 12, 2026 17:03
@brookfxg brookfxg merged commit 238608d into main Mar 12, 2026
5 checks passed
@brookfxg brookfxg deleted the brook/dc-666-add-support-for-session-custom-properties-to-foxglove-python branch March 12, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants