fix: don't send authorization headers with download links#158
Open
mguida22 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
One open risk before release: smoke-test the signed-URL paths — /v1/data/stream, /v1/data/upload, and the attachment redirect target — against a real backend. The whole change rests on those links needing no Authorization; if any still expects the Foxglove token, downloads/uploads will start 401ing once auth is stripped. Not verifiable from the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fix: authorization headers are no longer sent on requests to download links.
Docs
None
Description
Our download links use signed object store URLs. They don't need and shouldn't be sent auth headers that we use to communicate with the regular Foxglove API. This prevents sending headers by using a regular request for our download requests instead of our existing
__session.As part of this change I noticed it's possible for streaming responses to not properly close on error. This ensures we always close the response in a finally block.
In addition to tests here, I've tested that downloads still work properly via a local test script against our real backend.