Skip to content

fix: prune invalid/freed keys before typed-array assignments#622

Open
gk98s wants to merge 2 commits into
foxssake:mainfrom
gk98s:main
Open

fix: prune invalid/freed keys before typed-array assignments#622
gk98s wants to merge 2 commits into
foxssake:mainfrom
gk98s:main

Conversation

@gk98s

@gk98s gk98s commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Rather than modifying the synchronisers' core reparenting-preservation logic, this PR introduces a self-healing defensive prune inside Netfox's central data containers.

Before keys are fetched, assigned to typed arrays, or passed to prediction checks, the internal dictionaries are scanned for freed references via is_instance_valid(). Any dead references are safely erased from the dictionary before any typed array assignment takes place.

Fixes #621

@elementbound elementbound changed the title fix #621: prune invalid/freed keys before typed-array assignments fix: prune invalid/freed keys before typed-array assignments Jul 7, 2026
@elementbound

Copy link
Copy Markdown
Contributor

I'll look into the issue, but I'd much prefer not to filter the whole list on each query. My fear is that this could cause significant slowdowns.

@gk98s

gk98s commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Fair enough, I was too focused on fixing the errors I didn't notice the performance impact. I've just made an alternative fix that should be way better performance wise, and still fixes the crash and the errors I was having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: strict TypedArray validation crashes during unparented node deletion

2 participants