Wrapper to ensure {Crawls: []}

frankcash · Oct 26, 2019 · 2a41a2d · 2a41a2d
1 parent bff9be6
commit 2a41a2d
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 8 deletions.
diff --git a/helpers/index.js b/helpers/index.js
@@ -3,4 +3,8 @@ exports.url_refer = (url)=>{
         return url+="?utm_source=hackerqueue"
     }
     return url
-};
+};
+
+exports.wrap = (arr)=>{
+	return {Crawls: arr}
+}
diff --git a/routes/hackernews.js b/routes/hackernews.js
@@ -39,7 +39,7 @@ function parse(html){
 exports.htop = function(req,res){
   request('https://news.ycombinator.com', function(error, response, html){
       if(!error && response.statusCode === 200){
-        res.send({Crawls: parse(html, "news.ycombinator.com")});
+        res.send(helpers.wrap(parse(html, "news.ycombinator.com")));
       }
   });
 
@@ -48,7 +48,7 @@ exports.htop = function(req,res){
 exports.hnew = function(req,res){
   request('https://news.ycombinator.com/newest', function(error, response, html){
       if(!error && response.statusCode === 200){
-        res.send({Crawls: parse(html, "news.ycombinator.com/newest")});
+        res.send(helpers.wrap(parse(html, "news.ycombinator.com/newest")));
       }
   });
 

diff --git a/routes/lobsters.js b/routes/lobsters.js
@@ -90,8 +90,8 @@ const parseLobsterResponse = function(html) {
 exports.ltop = function(req, res){
   request('https://lobste.rs', function(error, response, html){
       if(!error && response.statusCode === 200){
-        let metadataArray = parseLobsterResponse(html);
-        res.send({Crawls: metadataArray});
+        const metadataArray = parseLobsterResponse(html);
+      	res.send(helpers.wrap(metadataArray));
       }
   });
 };
@@ -100,7 +100,7 @@ exports.lnew = function(req, res){
   request('https://lobste.rs/recent', function(error, response, html){
     if(!error && response.statusCode === 200){
       const metadataArray = parseLobsterResponse(html);
-      res.send({Crawls: metadataArray});
+      res.send(helpers.wrap(metadataArray));
     }
   });
 };
diff --git a/routes/reddit.js b/routes/reddit.js
@@ -54,7 +54,7 @@ function parse(html, source){
 exports.rtop = function(req,res){
   request('http://www.reddit.com/r/programming', function(error, response, html){
     if(!error && response.statusCode === 200){
-      res.send({Crawls: parse(html, "reddit.com/r/programming")});
+      res.send(helpers.wrap(parse(html, "reddit.com/r/programming")));
     }
   });
 };
@@ -63,7 +63,7 @@ exports.rtop = function(req,res){
 exports.rnew = function(req,res){
   request('http://www.reddit.com/r/programming/new/', function(error, response, html){
     if(!error && response.statusCode === 200){
-      res.send({Crawls: parse(html, "reddit.com/r/programming/new")});
+      res.send(helpers.wrap(parse(html, "reddit.com/r/programming/new")));
     }
   });
 };
diff --git a/test/metadata_wrapper.test.js b/test/metadata_wrapper.test.js
@@ -0,0 +1,11 @@
+const assert = require('assert');
+const helpers = require('../helpers');
+
+describe('MetaData Array Modification', ()=>{
+    describe("Wrapper", ()=>{
+      it("Shuld return a JSON object instead of an Array", function(){
+        const res = helpers.wrap([{url: "localhost:3000"}])
+				assert.equal(res.Crawls.length, 1)
+      });
+    });
+})