chore: added test case to check if multiple notifications are not sent on adding mention when edited

Author: aerodeval

helpdesk/helpdesk/doctype/hd_ticket_comment/test_hd_ticket_comment.py

@@ -11,6 +11,7 @@
     get_reactions,
     toggle_reaction,
 )
+from helpdesk.mixins.mentions import HasMentions
 from helpdesk.test_utils import create_agent
 
 
@@ -299,6 +300,84 @@ def test_no_notification_for_self_reaction(self):
 
         frappe.delete_doc("HD Ticket Comment", agent_comment.name, force=True)
 
+    def test_if_repeated_notification_sent_on_mention_add(self):
+        agent_one = self.agent_emails[0]
+        frappe.set_user(agent_one)
+        self.assign_agent(agent_one)
+
+        agent_comment = frappe.get_doc(
+            {
+                "doctype": "HD Ticket Comment",
+                "reference_ticket": self.test_ticket.name,
+                "content": """
+                <p>
+                    Hello
+                    <span class="mention"
+                        data-type="mention"
+                        data-id="[email protected]"
+                        data-label="Test User Two">
+                        @Test User Two
+                    </span>
+                </p>
+            """,
+                "commented_by": agent_one,
+                "owner": agent_one,
+            }
+        )
+
+        agent_comment.insert(ignore_permissions=True)
+        print(agent_comment)
+
+        notifications = frappe.get_all(
+            "HD Notification",
+            filters={
+                "reference_comment": agent_comment.name,
+                "notification_type": "Mention",
+            },
+            fields=["name", "user_to"],
+        )
+        print(notifications)
+        # notification one created should be equal to 1
+        self.assertEqual(len(notifications), 1)
+        self.assertEqual(notifications[0].user_to, "[email protected]")
+
+        agent_comment.content = """
+            <p>
+                Hello
+                <span class="mention"
+                    data-type="mention"
+                    data-id="[email protected]"
+                    data-label="Test User Two">
+                    @Test User Two
+                </span>
+                <span class="mention"
+                    data-type="mention"
+                    data-id="[email protected]"
+                    data-label="Test User One">
+                    @Test User One
+                </span>
+            </p>
+        """
+
+        agent_comment.save(ignore_permissions=True)
+        agent_comment.reload()
+        notifications_updated = frappe.get_all(
+            "HD Notification",
+            filters={
+                "reference_comment": agent_comment.name,
+                "notification_type": "Mention",
+            },
+            fields=["user_to"],
+        )
+        print("notificationsnow", notifications_updated)
+        print(agent_comment)
+
+        user_emails = {n.user_to for n in notifications_updated}
+
+        self.assertEqual(len(notifications_updated), 2)
+        self.assertIn("[email protected]", user_emails)
+        self.assertIn("[email protected]", user_emails)
+
     def test_grouped_notifications(self):
         test_users = self.agent_emails[3:6]
 

helpdesk/mixins/mentions.py

@@ -36,7 +36,14 @@ def notify_mentions(self, original_content=None):
             if self.doctype == "HD Ticket Comment":
                 values.reference_comment = self.name
                 values.reference_ticket = self.reference_ticket
-            if frappe.db.exists("HD Notification", values):
-                # avoid loop notification at first mention
+            if frappe.db.exists(
+                "HD Notification",
+                {
+                    "reference_comment": self.name,
+                    "user_to": mention.email,
+                    "notification_type": "Mention",
+                },
+            ):
+                # avoid loop of notification to quit at first mention
                 continue
             frappe.get_doc(values).insert()