Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get income tax slabs by getting ss_assignment based on from_date #1338

Merged
merged 7 commits into from
Jan 31, 2024
Merged

fix: get income tax slabs by getting ss_assignment based on from_date #1338

merged 7 commits into from
Jan 31, 2024

Conversation

KerollesFathy
Copy link
Contributor

@KerollesFathy KerollesFathy commented Jan 19, 2024 •
edited
Loading

Fixes #1333

@KerollesFathy KerollesFathy changed the title fix: get income tax slabs by getting ss_assignment based on from_date fix: get income tax slabs by getting ss_assignment based on from_date #1333 Jan 19, 2024
@KerollesFathy KerollesFathy changed the title fix: get income tax slabs by getting ss_assignment based on from_date #1333 fix: get income tax slabs by getting ss_assignment based on from_date Jan 19, 2024
@ruchamahabal
Copy link
Member

@KerollesFathy I am unable to make changes to your PR. Can you enable "Allow maintainers to edit the pull request"? We also avoid using MagicMock to test this since there are a lot of moving pieces in the actual doc structure which should also be tested. Can you add a test following the convention for other tests? Or you can allow me to edit the PR so that I can push changes here itself.

@KerollesFathy @ruchamahabal
remove spaces
52bd190 
Co-authored-by: Rucha Mahabal <[email protected]>
@KerollesFathy
Copy link
Contributor Author

@KerollesFathy I am unable to make changes to your PR. Can you enable "Allow maintainers to edit the pull request"? We also avoid using MagicMock to test this since there are a lot of moving pieces in the actual doc structure which should also be tested. Can you add a test following the convention for other tests? Or you can allow me to edit the PR so that I can push changes here itself.

Hi @ruchamahabal
Thanks for your review. unfortunately, I can't access the "Allow maintainers to edit the pull request" option. so I've invited you as a collaborator to our forked repo. Once accepted, you will have the ability to write on the PR and collaborate on writing tests.

@ruchamahabal ruchamahabal self-assigned this Jan 23, 2024
@ruchamahabal ruchamahabal force-pushed the fix-get-income-tax-slabs branch from be8a24d to 208a0a7 Compare January 31, 2024 13:22
@ruchamahabal ruchamahabal merged commit fe38ef2 into frappe:version-14-hotfix Jan 31, 2024
6 of 7 checks passed
frappe-pr-bot pushed a commit that referenced this pull request Jan 31, 2024
@frappe-bot
chore(release): Bumped to Version 14.21.4
19dd44f 
## [14.21.4](v14.21.3...v14.21.4) (2024-01-31)

### Bug Fixes

* get income tax slabs by getting ss_assignment based on from_date ([#1338](#1338)) ([fe38ef2](fe38ef2))
* typos (backport [#1351](#1351)) ([#1353](#1353)) ([3ae5354](3ae5354))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.21.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal left review comments

Assignees

@ruchamahabal ruchamahabal

Labels
released squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KerollesFathy @ruchamahabal @frappe-pr-bot