-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bulk Salary Structure Assignment #1367
Merged
ruchamahabal
merged 39 commits into
frappe:develop
from
krantheman:bulk-salary-structure-assignment
Mar 11, 2024
Merged
feat: Bulk Salary Structure Assignment #1367
ruchamahabal
merged 39 commits into
frappe:develop
from
krantheman:bulk-salary-structure-assignment
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y Structure Assignment
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1367 +/- ##
===========================================
- Coverage 73.06% 72.85% -0.22%
===========================================
Files 201 202 +1
Lines 11046 11153 +107
===========================================
+ Hits 8071 8125 +54
- Misses 2975 3028 +53
|
1 task
hrms/payroll/doctype/bulk_salary_structure_assignment/bulk_salary_structure_assignment.py
Outdated
Show resolved
Hide resolved
hrms/payroll/doctype/bulk_salary_structure_assignment/bulk_salary_structure_assignment.py
Outdated
Show resolved
Hide resolved
hrms/payroll/doctype/bulk_salary_structure_assignment/bulk_salary_structure_assignment.py
Outdated
Show resolved
Hide resolved
hrms/payroll/doctype/bulk_salary_structure_assignment/bulk_salary_structure_assignment.js
Show resolved
Hide resolved
Very clean implementation overall 👏 |
5686d50
to
7f60245
Compare
7f60245
to
3a9e51a
Compare
Co-authored-by: Rucha Mahabal <[email protected]>
2a2efe6
to
82ad53f
Compare
- move savepoint inside the for loop - let calling function handle errors and logging - fix logic for publishing progress - gets stuck if a failure occurs
ERPNext install is failing on develop. Merging this as its unrelated and tests are passing locally |
ruchamahabal
approved these changes
Mar 11, 2024
ruchamahabal
added a commit
that referenced
this pull request
Mar 11, 2024
…1367 feat: Bulk Salary Structure Assignment (backport #1367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk Salary Structure Assignment
This PR introduces the Bulk Salary Structure Assignment DocType, a replacement and enhancement to the Bulk Salary Structure Assignment Dialog.
The Problem - Bulk Salary Structure Assignment Dialog
Issues with the BSSA Dialog include, but are not limited to:
The Solution - Bulk Salary Structure Assignment DocType
bulk-salary-structure-assignment.mp4
Tackling the aforementioned issues, features of the BSSA DocType include:
Miscellaneous
In this PR, I have also:
notify_status
function by moving it fromleave_control_panely.py
toutils.py
.create_employee_grade
function by moving it fromtest_salary_structure.py
totest_utils.py
.Documentation
https://frappehr.com/docs/v14/en/salary-structure-assignment-tool