feat(minor): Show leave allocation table in Leave Application on refresh hook #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, leaves of draft leave applications with status 'Open' fall under the Leaves Pending Approval column, but other statuses are ignored. Maybe all draft leave applications should be considered as Pending Approval. @ruchamahabal thoughts? |
ruchamahabal
changed the title
ruchamahabal
changed the title
Yes makes sense. Can be covered in a separate PR |
ruchamahabal
approved these changes
Apr 17, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
…esh hook (#1375) * feat: Show leave allocation table on refresh hook * fix: show dashboard on draft applications only --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 6060aed)
ruchamahabal
pushed a commit
that referenced
this pull request
Apr 17, 2024
…esh hook (backport #1375) (#1675) * feat: Show leave allocation table on refresh hook * fix: show dashboard on draft applications only --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 6060aed) Co-authored-by: Niraj Gautam <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
# [15.19.0](v15.18.0...v15.19.0) (2024-04-18) ### Bug Fixes * conditional rendering for checkin ion-modal (backport [#1678](#1678)) ([#1679](#1679)) ([8afc06a](8afc06a)) ### Features * **minor:** Show leave allocation table in Leave Application on refresh hook (backport [#1375](#1375)) ([#1675](#1675)) ([888d383](888d383))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed:
refreshhook. This will allow managers to view the leaves allocated all the time.no-docsCloses: #1360