-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PWA): Push Notifications #1384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5268a1
to
876a29f
Compare
…initialization - use injectManifest to customize service worker - use injectRegister to control when it gets registered (after fetching firebase config)
0d97797
to
df1214e
Compare
…sw as classic instead of module - module type is not very reliable and the sw often stops running
545ef12
to
339097b
Compare
- move registration script to main.js - replace hardcoded relay server URL with the one fetched from boot
e6c38f5
to
892f338
Compare
feebd90
to
b4729c6
Compare
af17057
to
5526b06
Compare
ruchamahabal
added a commit
that referenced
this pull request
Mar 5, 2024
…1384 feat(PWA): Push Notifications (backport #1384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: frappe/frappe#24114
Co-authored by: @tanmoysrt
Documentation: https://frappehr.com/docs/v14/en/push-notifications