Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change server-action args #1398

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Feb 6, 2024

We accept flat argument instead of args now. Ref: frappe/frappe#24782

We accept flat argument instead of `args` now. Ref: frappe/frappe#24782
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f52fd55) 72.47% compared to head (6e67f45) 72.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1398   +/-   ##
========================================
  Coverage    72.47%   72.47%           
========================================
  Files          201      201           
  Lines        10985    10982    -3     
========================================
- Hits          7961     7959    -2     
+ Misses        3024     3023    -1     
Files Coverage Δ
hrms/hr/doctype/interview/interview.py 64.37% <100.00%> (-0.05%) ⬇️

@ruchamahabal ruchamahabal merged commit 80e6193 into frappe:develop Feb 6, 2024
7 checks passed
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
We accept flat argument instead of `args` now. Ref: frappe/frappe#24782

(cherry picked from commit 80e6193)
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
We accept flat argument instead of `args` now. Ref: frappe/frappe#24782

(cherry picked from commit 80e6193)

# Conflicts:
#	hrms/hr/doctype/interview/interview.py
@ankush ankush deleted the server-action branch February 6, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants