Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Income Tax Computation): eval locals for Income Tax Slab #1689

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

krantheman
Copy link
Member

All relevant fields are not included in evaluating condition of Income Tax Slab while generating Income Tax Computation report.

Example:

image

This PR fixes that.

@ruchamahabal
Copy link
Member

Unrelated flaky test failure. Merging

@ruchamahabal ruchamahabal merged commit e1d6118 into frappe:develop Apr 26, 2024
6 of 7 checks passed
@krantheman krantheman deleted the fix-income-tax-computation branch April 26, 2024 18:57
ruchamahabal added a commit that referenced this pull request Apr 26, 2024
…1689

fix(Income Tax Computation): eval locals for Income Tax Slab (backport #1689)
ruchamahabal added a commit that referenced this pull request Apr 26, 2024
…1689

fix(Income Tax Computation): eval locals for Income Tax Slab (backport #1689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants