Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Interview Feedback): type cast user input for "rating" field to float (backport #1799) #1801

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 22, 2024

Before: Data imported using CSV, throws "TypeError: unsupported operand type(s) for +=: 'int' and 'str'
" error when calculating average rating in Interview Feedback, because the rating being str.
After: Type cast rating to avoid incompatible user input


This is an automatic backport of pull request #1799 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from ruchamahabal as a code owner May 22, 2024 06:30
@ruchamahabal ruchamahabal merged commit cef40bd into version-15-hotfix May 22, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/version-15-hotfix/pr-1799 branch May 22, 2024 06:52
frappe-pr-bot pushed a commit that referenced this pull request May 22, 2024
## [15.21.1](v15.21.0...v15.21.1) (2024-05-22)

### Bug Fixes

* added missing args ([05ed004](05ed004))
* **Interview Feedback:** type cast user input for "rating" field to float (backport [#1799](#1799)) ([#1801](#1801)) ([cef40bd](cef40bd))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.21.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants