build: upgrade frappe-ui & related packages between both the workspaces #2370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frappe-ui is being used as a git submodule. It was upgraded to the latest version in both the yarn workspaces (frontend & roster) when roster got merged but submodule still pointed to a very old commit. So DateTimePicker import was failing.
Also, yarn "hoists" common dependencies and relies on a single lockfile for each submodule.
Started getting errors in PWA due to conflicting versions of vue installed:
[Vue warn]: Missing ref owner context. ref cannot be used on hoisted vnodes. A vnode with ref must be created inside the render function
This was because I had two different versions of Vue in
node_modules
(monorepo with multiple package.json with different versions of Vue)so I am upgrading common packages to the same version with:
yarn upgrade-interactive --latest <package-name>