-
Notifications
You must be signed in to change notification settings - Fork 359
feat: payer name & email from web form #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
batonac
wants to merge
31
commits into
frappe:develop
Choose a base branch
from
batonac:feat_payer_from_web_form
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify pyproject.toml and .gitignore to support newer versions of stripe.
…g debugging. Add custom_redirect_to_override option in stripe_settings.py finalize_request() so that the successful payment redirect address can be fully customized.
fmt: black & prettier
e7aba2a to
05b107c
Compare
bump all github actions and bring them to parity with erpnext
(cherry picked from commit bbcde03) Co-authored-by: Raffael Meyer <[email protected]>
05b107c to
0c09eb0
Compare
e55b682 to
9cec88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a feature to allow for sourcing the "Payer Name" and "Payer Email" in a payment gateway checkout form dynamically from web form fields.
Additionally, the Payment Form fields are cleaned up and moved to the dedicated "customizations API" custom fields JSON spec, instead relying on scripting to add and remove the custom fields.
The PR pre-supposes the removal of "Button Label" & "Button help" custom fields, as referenced in #4 and worked towards in #5.
Before (backend):
before.refactor_backend.mp4
After (backend):
after.refactor_backend.mp4
Before (frontend):
before.refactor_frontend.mp4
After (frontend):
after.refactor_frontend.mp4