-
Notifications
You must be signed in to change notification settings - Fork 224
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(revisions): minor ux improvements
fix #232 - put content in scrollable div, so that user can see info all the time - change button position - show close button - move edited info below title
- Loading branch information
1 parent
30a00e4
commit 8435daf
Showing
2 changed files
with
25 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,30 @@ | ||
<div class="modal revisions-modal fade" id="revisionsModal" tabindex="-1" role="dialog" | ||
aria-labelledby="revisionsModalTitle" aria-hidden="true"> | ||
<div class="modal-dialog modal-dialog-centered" role="document"> | ||
<div class="modal-dialog modal-lg modal-dialog-centered" role="document"> | ||
<div class="modal-content"> | ||
<div class="modal-header"> | ||
<h5 class="modal-title revision-title" id="revisionsModalTitle">{{ title }}</h5> | ||
<button type="button" class="d-block d-sm-none close" data-dismiss="modal" aria-label="Close"> | ||
<div class="d-flex flex-column"> | ||
<h5 class="modal-title revision-title" id="revisionsModalTitle">{{ title }}</h5> | ||
<span class="small text-muted revision-time">{{ current_revision.raised_by_username or | ||
current_revision.raised_by or | ||
current_revision.owner }} edited {{ | ||
frappe.utils.pretty_date(current_revision.creation) }}</span> | ||
</div> | ||
<button type="button" class="close" data-dismiss="modal" aria-label="Close"> | ||
<span aria-hidden="true">×</span> | ||
</button> | ||
<span class="small text-muted revision-time">{{ current_revision.raised_by_username or current_revision.raised_by or | ||
current_revision.owner }} edited {{ | ||
frappe.utils.pretty_date(current_revision.creation) }}</span> | ||
</div> | ||
<div class="modal-body"> | ||
<div class="revision-content wiki-content"> | ||
{{ frappe.utils.md_to_html(previous_revision.content) }} | ||
</div> | ||
</div> | ||
<div class="modal-footer"> | ||
<button type="button" data-modal-button="previous" class="previous-revision btn btn-secondary btn-sm hide">Previous</button> | ||
<button type="button" data-modal-button="next" class="next-revision btn btn-secondary btn-sm hide">Next</button> | ||
<div class="modal-footer d-flex justify-content-between"> | ||
<button type="button" data-modal-button="previous" | ||
class="previous-revision btn btn-secondary btn-sm hide">Previous</button> | ||
<button type="button" data-modal-button="next" | ||
class="next-revision btn btn-secondary btn-sm hide">Next</button> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> |