-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PluginEntry #75
base: next
Are you sure you want to change the base?
PluginEntry #75
Conversation
I'm still having a really hard time understanding this here's a clap entry I wrote recently https://github.com/baconpaul/sapphire-plugins/blob/main/src/clap/sapphire-clap-entry.cpp and here's the implementation, implementing the plugin, vst3, and auv2 factory for a 4 plugin clap https://github.com/baconpaul/sapphire-plugins/blob/main/src/clap/sapphire-clap-entry-impl.cpp i'm not sure what would change if I used this code. Where would I put these objects? |
to derived classes
f94cb73
to
73584f4
Compare
hey @baconpaul I played around with this a bit and did a demo branch on how the code would change There was also a missing bit that I just added (the not sure whether you'll like it for your project but there it is at least 😅 |
Co-authored-by: Dalton Messmer <[email protected]>
first version for a + clap::helpers::PluginEntry`
CLAP_HELPERS_UNLIKELY
might be nice for some of the checksplugin_path
onplugin_entry.init
could be checked better (whether it's actually a valid path, see TODO comment)resolves #74 (this is a more general approach and leaves the actual implementation more up to the user which i think is better)