-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(documentation): Add documentation support for three.js #2392
Merged
simon04
merged 14 commits into
freeCodeCamp:main
from
chaitanyarahalkar:add/threejs-docs
Feb 23, 2025
Merged
feat(documentation): Add documentation support for three.js #2392
simon04
merged 14 commits into
freeCodeCamp:main
from
chaitanyarahalkar:add/threejs-docs
Feb 23, 2025
+384
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @ojeytonwilliams @simon04! Let me know your thoughts on the PR. Thank you! |
simon04
approved these changes
Feb 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public/icons/threejs/
directory:16.png
: a 16×16 pixel icon for the doc16@2x.png
: a 32×32 pixel icon for the docSOURCE
: A text file containing the URL to the page the image can be found on or the URL of the original image itselfAddressed issue #2351
This PR adds documentation support for
three.js
. The parsers for this were slightly complicated sincethree.js
uses a different mechanism to render its documentation. TheFileScraper
based approach is used where the documentation is first downloaded and then the parser is applied on the locally downloaded files.