Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action CI checks #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ngie-eign
Copy link
Contributor

@ngie-eign ngie-eign commented Dec 27, 2024

This is almost entirely based on work submitted by @kevemueller in #81 .

I took the liberty of cleaning it up in a followup commit so it would better match established build methodologies and be yamllint clean (more detail is in the second commit).

Example run: https://github.com/ngie-eign/atf/actions/runs/12520930757.

@ngie-eign
Copy link
Contributor Author

@kevemueller: if there's another email address you'd like me to use in the commit message, please let me know.

ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/lutok that referenced this pull request Dec 27, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 28, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 29, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 29, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 29, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 29, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 29, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
ngie-eign added a commit to ngie-eign/kyua that referenced this pull request Dec 29, 2024
This proposed GitHub Actions workflow file runs tests on MacOS and
Ubuntu Linux, similar to what is being proposed in
freebsd/atf#93 .

The delta between this change and the one being made in ATF mostly
relates to the additional package dependencies, e.g., with and without
ATF.

Kyua is built from scratch because of issues with dependent packages and
runtime linker collisions on both MacOS and Ubuntu. The binary package
versions are built against a different version of Lutok, ergo they can
have runtime linker collisions.

Signed-off-by: Enji Cooper <[email protected]>
Keve and others added 2 commits December 29, 2024 12:14
…figurations

Build on macOS Sonoma/aarch64 and Ubuntu 24.04/amd64.
- Clean up the YAML to make it yamllint clean
- Remove some references to sanitizers so the code is isolated/standalone.
- Change branch from `main` to `master`, since development mainline is
  still `master`, not `main`.
- Rename the steps for human consumption.
- Change the environment variable names in the "Setup Environment" step
  to match a scheme that's easier to sort and to align better with
  established build methodologies (srcdir, objdir, prefix).
- Use `installcheck` instead of `installcheck-kyua`.

Signed-off-by: Enji Cooper <[email protected]>
- ubuntu-24.04
- macos-latest
sanitize:
- []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone new to GH actions this is non-obvious to me

@emaste
Copy link
Member

emaste commented Dec 29, 2024

Can we perhaps add FreeBSD support via https://github.com/vmactions/freebsd-vm (until GH Actions has native FreeBSD support)?

@asomers
Copy link
Member

asomers commented Dec 30, 2024

Can we perhaps add FreeBSD support via https://github.com/vmactions/freebsd-vm (until GH Actions has native FreeBSD support)?

It's easier to use Cirrus CI, IMHO, because it supports FreeBSD natively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants