Fix early debug#2704
Merged
Merged
Conversation
* Initialize ctx.debug_flags to all-bits-one so pkg_dbg() can be used before pkg_ini() read the configuration. * In pkg_ini(), only set ctx.debug_level if the new value (from the configuration or environment) is greater than the current value.
Now that pkg_ini() no longer clears the debug level, it is enough to set it once, immediately after the getopt_long() loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpkg: Fix early debug
Initialize
ctx.debug_flagsto all-bits-one sopkg_dbg()can be usedbefore
pkg_ini()has read the configuration.In
pkg_ini(), only setctx.debug_levelif the new value (from theconfiguration or environment) is greater than the current value.
main: Don't set debug level twice
Now that
pkg_ini()no longer clears the debug level, it is enough to setit once, immediately after the
getopt_long()loop.