Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax of systemd's ConditionPathExists #7434

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jan 31, 2025

Status

Ready for review

Description of Changes

systemd prefers =|, not |=.

Fixes #7412.

Testing

How should the reviewer test this PR?

  • visual review, cross-reference with systemd syntax if you want
  • if you really really want, run systemctl daemon-reload on a staging/prod system and see that it doesn't emit warnings about the wrong syntax.

I initially held off because I wanted a regression test, and Ro is working on one in the workstation, so let's just get this in now and we can land the regression test later, as a non-release blocker.

Deployment

Any special considerations for deployment? n/a

Checklist

systemd prefers =|, not |=.

Fixes #7412.
@legoktm legoktm added this to the SecureDrop 2.12.0 milestone Jan 31, 2025
@legoktm legoktm requested a review from a team as a code owner January 31, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Syntax error in securedrop-remove-packages.service ConditionPathExists
1 participant