Change location of config files and runtime data #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ | |||
| class Config(object): | |||
| development_config = ('freeipa_community_portal/conf/' | |||
| 'freeipa_community_portal_dev.ini') | |||
| deployment_config = '/etc/freeipa_community_portal.ini' | |||
| deployment_config = '/etc/ipa/extensions/community-portal/portal.ini' | |||
There was a problem hiding this comment.
These same string literals appear in freeipa-portal-install and create-portal-user.
We should define them here in the lib and import from the scripts.
There was a problem hiding this comment.
We can get rid of freeipa-portal-install as soon as we have RPM packages.
For create-portal-user I'm planning to use freeipa_community_portal.config in the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch makes the location of config files and runtime data more consistent with the rest of FreeIPA. Alexander has suggested /etc/ipa/extensions as root for all IPA extensions.