Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Handle PKI >= 11.5.0 not storing certs in CS.cfg #319

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

rcritten
Copy link
Collaborator

Update the test to expect 0 results if the PKI version is

= 11.5.0.

Fixes: #317

This wasn't caught during development or by CI because PKI 11.5.0 is not available yet.

Update the test to expect 0 results if the PKI version is
>= 11.5.0.

Fixes: freeipa#317

Signed-off-by: Rob Crittenden <[email protected]>
@rcritten
Copy link
Collaborator Author

@flo-renaud
Copy link
Contributor

@rcritten thanks for the patch, works for me.

Installed PKI 11.5 from copr repo @pki/master + freeipa from @freeipa/freeipa-master-nightly
Run pytest without the patch: produces 2 errors

=================================================================== short test summary info ===================================================================
FAILED tests/test_dogtag_ca.py::TestCACerts::test_ca_certs_ok - assert 0 == 6
FAILED tests/test_dogtag_ca.py::TestCACerts::test_cert_missing_from_file - IndexError: list index out of range
==================================================== 2 failed, 187 passed, 2 xpassed, 4 warnings in 3.14s =====================================================

Run pytest with the patch: the failing tests are skipped

==================================================== 187 passed, 2 skipped, 2 xpassed, 4 warnings in 3.12s ====================================================

@flo-renaud flo-renaud self-assigned this Jan 15, 2024
@flo-renaud flo-renaud added the ack label Jan 15, 2024
@rcritten rcritten merged commit 3d85d43 into freeipa:master Jan 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants