Improve checkmark toggle logic #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the description above is supposed to say "Fixes #29"? |
|
But I like the look of this! Maybe I will test shortly. |
|
Tested and I can confirm that this fixes #29. |
aspiers
added a commit
to rolod0x/rolod0x
that referenced
this pull request
Jan 21, 2024
This is from fregante/webext-permission-toggle#38 which is a better fix for fregante/webext-permission-toggle#29 than my own in fregante/webext-permission-toggle#33
aspiers
added a commit
to rolod0x/rolod0x
that referenced
this pull request
Jan 21, 2024
This is from fregante/webext-permission-toggle#38 which is a better fix for fregante/webext-permission-toggle#29 than my own in fregante/webext-permission-toggle#33
|
It seems to work in my tests too 🙌 Thanks for starting the discussion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely untested at this point. Will review once I have more time