Skip to content

Conversation

@RAPTOR7762
Copy link
Contributor

Work in progress

@RAPTOR7762
Copy link
Contributor Author

Hi Kjell, once I'm done can you help me run this against it, befor I mark this as completed; ready for review?

@KjellMorgenstern
Copy link
Member

KjellMorgenstern commented Jun 23, 2025

The current behavior of Fritzing, to add a prefix0000 is a bit confusing, and only very limited help to avoid duplicate filenames.
Using a uuid in the filename works to avoid name collisions. In the part format discussion, we currently drafted
in #369 :
"File name conventions: Use a "_versionnumber" or a "_hash" at the end of the file name. e,g: fc-51_1.fzp. Avoid spaces and brackets. Use underscore symbols."

Although this was for the fzp filename, it could be applied to the views:
So, fc-51_3.svg would match this, but you could also use fc-51_0c9711422ad29606f2b6bb1ec42bc763.svg .

It might be more descriptive to put the _[view] in there, but that wil be duplicate information in many cases:
The view is defined in the fzp file itself. Again, for fzpz, with a [view]. prefix. And for fzp files by the svg/[view]/ directory name. And also, within the svg, with the layer id.
Also, when looking at the actual image, it is usually very obvious which view it is, except maybe for icon views.

@RAPTOR7762
Copy link
Contributor Author

i think there are minor errors and one major one -- the trailing px for font size in icon SVG

@RAPTOR7762 RAPTOR7762 marked this pull request as ready for review June 24, 2025 11:38
@RAPTOR7762
Copy link
Contributor Author

Hi @KjellMorgenstern Are you going to merge this and add to Fritzing 1.0.6? After looking at the logs there isn't anything wrong with the part

@KjellMorgenstern KjellMorgenstern added this to the 1.0.6 milestone Jun 24, 2025
@KjellMorgenstern
Copy link
Member

In the description of a PR, you should link back to the issue, so we don't need to guess what the original problem was.
Something like:
Fixes #409

@KjellMorgenstern KjellMorgenstern self-requested a review June 24, 2025 15:16
@RAPTOR7762
Copy link
Contributor Author

Ok will do that in the future!

@RAPTOR7762
Copy link
Contributor Author

OK @KjellMorgenstern I've added the changedby="" attribute

@RAPTOR7762
Copy link
Contributor Author

Hi @KjellMorgenstern

Are you going to add this to v1.0.7

@RAPTOR7762 RAPTOR7762 closed this by deleting the head repository Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants