Skip to content

Conversation

@RAPTOR7762
Copy link
Contributor

@RAPTOR7762 RAPTOR7762 commented Oct 25, 2025

@KjellMorgenstern Addressed #426. Can you add this part to Fritzing 1.0.7? Ready for review

@KjellMorgenstern KjellMorgenstern added this to the 1.0.7 milestone Oct 30, 2025
@KjellMorgenstern
Copy link
Member

The part is scheduled for 1.0.7.

I see I need to update the github workflow to run the checker.

@KjellMorgenstern
Copy link
Member

@RAPTOR7762 There is a report about some (minor) problems here:

https://github.com/fritzing/fritzing-parts/actions/runs/18935939327/job/54062887256#step:7:92

The latest version of the checker script should be able fix these automatically if you run it with the "--fix" option.

Of course you can also fix manually, for some errors there is not automatic fix. But hopefully the new report after running the check is now much better to read.

@KjellMorgenstern
Copy link
Member

A markdown version of the result is also shown here: https://github.com/fritzing/fritzing-parts/actions/runs/18936649301?pr=427 .

Removed 'gorn' attribute from two connector pins.
Updated date format and added placeholders for missing properties.
@RAPTOR7762
Copy link
Contributor Author

OK fixed @KjellMorgenstern

@RAPTOR7762
Copy link
Contributor Author

@KjellMorgenstern ?

@KjellMorgenstern KjellMorgenstern merged commit 1276129 into fritzing:develop Nov 2, 2025
3 of 6 checks passed
@failiz
Copy link
Contributor

failiz commented Nov 10, 2025

Nice part. However, the schematic symbol could be improved by (1) shortening the long stroke to not touch the outside circle and (2) follow the convention in electronics where positive is up and negative down or, in other words, rotating the symbol 90 degrees so the positive side is up and the negative down. I did not test this in Fritzing and maybe it already appears like that when you drag it to the program, but the svg appears rotated.
The second issue is present in several batteries in the core, and it is a bit difficult to fix without obsoleting them. But this part is new and easier to fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants