-
Notifications
You must be signed in to change notification settings - Fork 376
Add generic small 6V solar panel #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The part is scheduled for 1.0.7. I see I need to update the github workflow to run the checker. |
8341a25 to
4adeb4a
Compare
|
@RAPTOR7762 There is a report about some (minor) problems here: https://github.com/fritzing/fritzing-parts/actions/runs/18935939327/job/54062887256#step:7:92 The latest version of the checker script should be able fix these automatically if you run it with the "--fix" option. Of course you can also fix manually, for some errors there is not automatic fix. But hopefully the new report after running the check is now much better to read. |
4adeb4a to
1485d0b
Compare
|
A markdown version of the result is also shown here: https://github.com/fritzing/fritzing-parts/actions/runs/18936649301?pr=427 . |
Removed 'gorn' attribute from two connector pins.
Updated date format and added placeholders for missing properties.
|
OK fixed @KjellMorgenstern |
|
Nice part. However, the schematic symbol could be improved by (1) shortening the long stroke to not touch the outside circle and (2) follow the convention in electronics where positive is up and negative down or, in other words, rotating the symbol 90 degrees so the positive side is up and the negative down. I did not test this in Fritzing and maybe it already appears like that when you drag it to the program, but the svg appears rotated. |
@KjellMorgenstern Addressed #426. Can you add this part to Fritzing 1.0.7? Ready for review