Add test cases for Loader #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
shinnya
commented
Mar 5, 2019
|
|
||
| #[derive(Debug)] | ||
| /// Note: Give desired implementations if needed. | ||
| struct NullIo(ClusterConfig); |
There was a problem hiding this comment.
NullIo は削除して、まともにテストで使えるように TestIo として再実装。
| } | ||
|
|
||
| #[test] | ||
| fn it_fails_if_log_suffix_contains_older_term() -> TestResult { |
| } else { | ||
| false | ||
| } | ||
| self.role.is_loader() |
There was a problem hiding this comment.
コードを整理して、触ったコードに関わる箇所はテストを追加。
| logs: Arc<Mutex<HashMap<(LogIndex, Option<LogIndex>), Log>>>, | ||
| } | ||
|
|
||
| impl TestIoHandle { |
There was a problem hiding this comment.
何がテストに必要なのか分かっていない部分が多いので、ブラッシュアップしていく前提で一旦あると便利な機能を追加。Io の所有権を放棄した上で細かくテストシナリオを操作できるように Handle を実装してます。
| /// `LoadBallot` でロードされる。 | ||
| pub ballots: Arc<Mutex<Vec<Ballot>>>, | ||
| /// `LoadLog` でロードされる。 | ||
| pub logs: Arc<Mutex<HashMap<(LogIndex, Option<LogIndex>), Log>>>, |
There was a problem hiding this comment.
あらかじめ Log や Ballot を仕込んでおき、それらを run_once で上手くロードさせるようにコントロールしながらテストしていく方針。
yuezato
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
テスト用の Io 実装とそれを使ったテストを追加。