FS-1006 struct tuples #30
Open
+64
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@T-Gro Any change we can get a review. |
T-Gro
reviewed
Feb 17, 2025
| @@ -355,6 +365,9 @@ example, `typeof<int * int>` is equivalent to `typeof<System.Tuple<int,int>>`, a | |||
| runtime type `System.Tuple<int,int>`. Likewise, `(1,2,3,4,5,6,7,8,9)` has the runtime type | |||
| `Tuple<int,int,int,int,int,int,int,Tuple<int,int>>`. | |||
|
|
|||
| Tuple types and expressions that have `S` resolved to struct tuple are translated in the same way to `System.StructTuple`. | |||
|
|
|||
|
|
|||
| > Note: The above encoding is invertible and the substitution of types for type variables | |||
| preserves this inversion. This means, among other things, that the F# reflection library | |||
| can correctly report tuple types based on runtime System.Type values. The inversion is | |||
There was a problem hiding this comment.
Suggested change
| can correctly report tuple types based on runtime System.Type values. The inversion is | |
| can correctly report tuple types based on runtime System.Type and System.ValueTuple values. The inversion is |
T-Gro
reviewed
Feb 17, 2025
| @@ -355,6 +365,9 @@ example, `typeof<int * int>` is equivalent to `typeof<System.Tuple<int,int>>`, a | |||
| runtime type `System.Tuple<int,int>`. Likewise, `(1,2,3,4,5,6,7,8,9)` has the runtime type | |||
| `Tuple<int,int,int,int,int,int,int,Tuple<int,int>>`. | |||
|
|
|||
| Tuple types and expressions that have `S` resolved to struct tuple are translated in the same way to `System.StructTuple`. | |||
There was a problem hiding this comment.
Suggested change
| Tuple types and expressions that have `S` resolved to struct tuple are translated in the same way to `System.StructTuple`. | |
| Tuple types and expressions that have `S` resolved to struct tuple are translated in the same way to [System.ValueTuple](https://learn.microsoft.com/dotnet/api/system.valuetuple) . |
T-Gro
reviewed
Feb 17, 2025
|
|
||
| A _struct tuple expression_ is checked in the same way as a _tuple expression_, but the pseudo-type `S` is resolved to struct tuple. | ||
|
|
||
| Tuple types and expressions that have `S` resolved to reference tuple are translated into applications of a family of F# library types named |
There was a problem hiding this comment.
Suggested change
| Tuple types and expressions that have `S` resolved to reference tuple are translated into applications of a family of F# library types named | |
| Tuple types and expressions that have `S` resolved to reference tuple are translated into applications of a family of .NET types named |
T-Gro
reviewed
Feb 17, 2025
| A _struct tuple expression_ is checked in the same way as a _tuple expression_, but the pseudo-type `S` is resolved to struct tuple. | ||
|
|
||
| Tuple types and expressions that have `S` resolved to reference tuple are translated into applications of a family of F# library types named | ||
| `System.Tuple`. Tuple types `ty1 * ... * tyn` are translated as follows: |
There was a problem hiding this comment.
Suggested change
| `System.Tuple`. Tuple types `ty1 * ... * tyn` are translated as follows: | |
| [System.Tuple](https://learn.microsoft.com/dotnet/api/system.tuple). Tuple types `ty1 * ... * tyn` are translated as follows: |
T-Gro
reviewed
Feb 17, 2025
| struct ( ty 1 * ... * tyn ) | ||
| ``` | ||
|
|
||
| The elaborated form of a tuple type is shorthand for a use of the family of F# library types |
There was a problem hiding this comment.
Suggested change
| The elaborated form of a tuple type is shorthand for a use of the family of F# library types | |
| The elaborated form of a tuple type is shorthand for a use of the family of .NET types |
T-Gro
reviewed
Feb 17, 2025
| ``` | ||
|
|
||
| The elaborated form of a tuple type is shorthand for a use of the family of F# library types | ||
| `System.StructTuple<_, ..., _>`. |
There was a problem hiding this comment.
Suggested change
| `System.StructTuple<_, ..., _>`. | |
| [System.ValueTuple](https://learn.microsoft.com/dotnet/api/system.valuetuple). |
T-Gro
reviewed
Feb 17, 2025
|
|
||
| When considered as static types, tuple types are distinct from their encoded form. However, the | ||
| encoded form of tuple types is visible in the F# type system through runtime types. For example, | ||
| `typeof<int * int>` is equivalent to `typeof<System.StructTuple<int,int>>`. |
There was a problem hiding this comment.
Suggested change
| `typeof<int * int>` is equivalent to `typeof<System.StructTuple<int,int>>`. | |
| `typeof<int * int>` is equivalent to `typeof<System.ValueTuple<int,int>>`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "struct tuples" according to FS-1006 to the types, expressions, patterns and inference chapters.