Skip to content

Try using File.ResolveLinkTarget instead of Mono.Unix.UnixPath.GetRea… #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Try using File.ResolveLinkTarget instead of Mono.Unix.UnixPath.GetRea… #2882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/app/Fake.DotNet.Cli/DotNet.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,12 +831,32 @@ module DotNet =

let currentDotNetRoot = Environment.environVar "DOTNET_ROOT"

// resolve potential symbolic link to the real location
// On .NET we can use File.ResolveLinkTarget, on .NET Standard we use Mono.Unix.UnixPath.GetRealPath
let resolveLinkTarget linkPath =

let resolvedPath =
#if NET
// ResolveLinkTarget returns null if the input isn't a link. Just use the input path directly in that case.
// @@TODO@@ ResolveLinkTarget might throw if the input doesn't exist - maybe need to handle that.
let resolvedTarget = File.ResolveLinkTarget(linkPath, true)

if isNull resolvedTarget then
linkPath
else
resolvedTarget.FullName
#else
// https://stackoverflow.com/questions/58326739/how-can-i-find-the-target-of-a-linux-symlink-in-c-sharp
Mono.Unix.UnixPath.GetRealPath(dotnetTool)
#endif

resolvedPath |> Path.GetDirectoryName

let realFolder =
if not Environment.isWindows then
#if !FX_NO_POSIX
// resolve potential symbolic link to the real location
// https://stackoverflow.com/questions/58326739/how-can-i-find-the-target-of-a-linux-symlink-in-c-sharp
Mono.Unix.UnixPath.GetRealPath(dotnetTool) |> Path.GetDirectoryName
resolveLinkTarget dotnetTool
#else
eprintf
"Setting 'DOTNET_ROOT' to '%s' this might be wrong as we didn't follow the symlink. Please upgrade to netcore."
Expand Down
Loading