Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of
andto
functions, additional operators #6New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
of
andto
functions, additional operators #6Changes from 3 commits
699149e
c48ed91
7ffb719
d7dcaa1
0bf7f41
cb529b0
ac976e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the R3 exception handling significantly differs from Rx, this could need some xml comments as well. (R3 docs: "Stopping the pipeline at OnError is a mistake.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added XML comment with remarks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate this "sigleton" because it reminds people of OO GoF desgin-pattern of singleton which this is not, this is not a static instance and there can be more by just merging this. This is rather "lift my value to this computation expression", I don't know if there are better more F#pish names like Option.ofObj or Task.FromResult.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it looks strange. I see such naming is used in Java https://www.javatpoint.com/java-collections-singleton-method and Haskell too.
https://github.com/dotnet/fsharp/blob/a90f6d1b7573053e385a008da589233397bec48b/src/FSharp.Core/seqcore.fs#L133