Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WorldBank url to https; fixes #1514 #1515

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Change WorldBank url to https; fixes #1514 #1515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/library/JsonProvider.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ let doc = WorldBank.GetSample()
(** Note that we can also load the data directly from the web both in the `Load` method and in
the type provider sample parameter, and there's an asynchronous `AsyncLoad` method available too: *)
let wbReq =
"http://api.worldbank.org/country/cz/indicator/"
"https://api.worldbank.org/country/cz/indicator/"
+ "GC.DOD.TOTL.GD.ZS?format=json"

let docAsync = WorldBank.AsyncLoad(wbReq)
Expand Down
2 changes: 1 addition & 1 deletion docs/library/JsonValue.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ let value = JsonValue.Load(__SOURCE_DIRECTORY__ + "../../data/WorldBank.json")
asynchronous version available too: *)

let wbReq =
"http://api.worldbank.org/country/cz/indicator/"
"https://api.worldbank.org/country/cz/indicator/"
+ "GC.DOD.TOTL.GD.ZS?format=json"

let valueAsync = JsonValue.AsyncLoad(wbReq)
Expand Down
2 changes: 1 addition & 1 deletion src/FSharp.Data.DesignTime/WorldBank/WorldBankProvider.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type public WorldBankProvider(cfg: TypeProviderConfig) as this =
let asm = System.Reflection.Assembly.GetExecutingAssembly()
let ns = "FSharp.Data"

let defaultServiceUrl = "http://api.worldbank.org/v2"
let defaultServiceUrl = "https://api.worldbank.org/v2"
let cacheDuration = TimeSpan.FromDays 30.0
let restCache = createInternetFileCache "WorldBankSchema" cacheDuration

Expand Down
2 changes: 1 addition & 1 deletion ...xpected/WorldBank,World Development Indicators;Global Financial Development,True.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
class WorldBankDataProvider : obj
static member GetDataContext: () -> WorldBankDataProvider+ServiceTypes+WorldBankDataService
(new WorldBankData("http://api.worldbank.org", "World Development Indicators;Global Financial Development"))
(new WorldBankData("https://api.worldbank.org", "World Development Indicators;Global Financial Development"))


class WorldBankDataProvider+ServiceTypes : obj
Expand Down
Loading