[repo-assist] perf: avoid sprintf overhead for no-arg format strings in HtmlFormatting - #1271
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
Replace sprintf "<pre><code>" with a plain string literal in three call sites within the hot code/output block rendering path. sprintf with zero format specifiers still incurs printf-format parsing overhead on every call; a plain literal avoids that with no behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
What: Replaces
sprintf "<pre><code>"(a format string with no format specifiers) with the plain string literal"<pre><code>"at three call sites inHtmlFormatting.fs.Why: This code path runs once per rendered code/output block during Markdown-to-HTML formatting (used throughout
fsdocsdoc generation).sprintfwith zero substitutions still goes through F#'s printf-format parsing machinery on every call, which is pure overhead for a constant string. A plain literal is functionally identical and avoids that cost.Scope: Purely mechanical, behavior-preserving change — no other code touched.
Test Status
dotnet fantomason the changed file: unchanged (already formatted).dotnet build src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj --configuration Release: succeeded, 0 warnings/errors.dotnet test tests/FSharp.Markdown.Tests --configuration Release: 368/368 passed.Add this agentic workflow to your repo
To install this agentic workflow, run