net8.0-windows target issue #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! released in 8.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for addressing the issue in #4241 which was caused by mismatching conditions in the
paket.propsfile in theobjfolder of a project.When net8.0 support was added the
net8.0-windowsand os specificnet8.0targets were left on TargetFrameworkVersionv7.0accidentally, which caused mismatch in the above mentioned file.Also
net8.0-windowsseems to be defaulting tonet8.0-windows7.0instead ofnet8.0-windows10.0.17763.0, therefore the TargetPlatformVersion is also mismatching, so thePackageReferenceis not added duringDesignTimeAlso attached a simple project that reproduces the problem.
repro4241.zip