Call cat_ranges in blockcache for async filesystems #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monken
force-pushed
the
blockcache-cat-ranges
branch
3 times, most recently
from
1c95789 to
09d06d8
Compare
monken
force-pushed
the
blockcache-cat-ranges
branch
from
09d06d8 to
46ea642
Compare
martindurant
reviewed
Oct 4, 2023
|
Sorry I let this one slide - I still think it's useful. I have just the one comment above. |
monken
force-pushed
the
blockcache-cat-ranges
branch
from
46ea642 to
1fd8c23
Compare
|
Can you please solve the conflict, and I can have another look? |
monken
force-pushed
the
blockcache-cat-ranges
branch
from
1fd8c23 to
4dbb984
Compare
monken
force-pushed
the
blockcache-cat-ranges
branch
from
4dbb984 to
a048e26
Compare
|
@martindurant sorry that I abandoned this for so long. I fixed the merge conflicts and updated the tests. Please let me know if you still deem this valuable. |
| @@ -37,6 +37,7 @@ | |||
| logger = logging.getLogger("fsspec") | |||
|
|
|||
| Fetcher = Callable[[int, int], bytes] # Maps (start, end) to bytes | |||
| MultiFetcher = Callable[list[[int, int]], bytes] # Maps [(start, end)] to bytes | |||
There was a problem hiding this comment.
Hi @monken @martindurant,
Unfortunately, this change breaks the usage of this library in Python 3.8. It's simple to reproduce:
from typing import Callable
X = Callable[list[[int, int]], bytes]Would it be possible to yank 2025.3.1 (at least while support for 3.8 is still being maintained)? Thanks!
There was a problem hiding this comment.
I will yank, but I 2025.3.1 will henceforth only support >=3.9; it should have probably been done before now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CachingFileSystem can benefit from calling
cat_rangesfor asynchronous filesystems to concurrently download blocks. This speeds up filling the cache significantly for filesystems like HTTP and S3FS.