-
Notifications
You must be signed in to change notification settings - Fork 376
spec: normalize the key for _ls_from_cache #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: normalize the key for _ls_from_cache #557
Conversation
@martindurant do you have access to a databricks instance? It appears to be that some operations doesn't invalidate the cache as of now (like .rm()/.mv() etc) which is uncovered by this PR though since I don't have access to such instance I am unable to record VCRs and test them in the CI. It would be much appreciated if you could push the latest recordings to my branch (or help me to setup in another way). |
No, I'm afraid I don't |
I have created a PR with fixed cassettes. Thanks for the mention! |
Thanks for regenerating cassettes @nils-braun |
Do you have time to run the s3fs tests and figure out why two tests are failing? It may not be a coincidence that moto 2.0 was just released (i.e., setting the install req to <2 might fix this) |
rerunning |
Oh dear, I'm sorry: it needs changing in this repo in tox.ini under |
2bce07d
to
4f4edcb
Compare
Resolves #554