Skip to content

spec: normalize the key for _ls_from_cache #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2021

Conversation

isidentical
Copy link
Member

Resolves #554

@isidentical
Copy link
Member Author

@martindurant do you have access to a databricks instance? It appears to be that some operations doesn't invalidate the cache as of now (like .rm()/.mv() etc) which is uncovered by this PR though since I don't have access to such instance I am unable to record VCRs and test them in the CI. It would be much appreciated if you could push the latest recordings to my branch (or help me to setup in another way).

@martindurant
Copy link
Member

No, I'm afraid I don't

cc @nils-braun @andersy005

@nils-braun
Copy link
Contributor

I have created a PR with fixed cassettes. Thanks for the mention!

@isidentical
Copy link
Member Author

Thanks for regenerating cassettes @nils-braun

@isidentical isidentical closed this Mar 5, 2021
@isidentical isidentical reopened this Mar 5, 2021
@martindurant
Copy link
Member

Do you have time to run the s3fs tests and figure out why two tests are failing? It may not be a coincidence that moto 2.0 was just released (i.e., setting the install req to <2 might fix this)

@martindurant
Copy link
Member

rerunning

@martindurant
Copy link
Member

Oh dear, I'm sorry: it needs changing in this repo in tox.ini under [testenv:s3fs]/conda_deps

@isidentical isidentical force-pushed the normalization-ls-from-cache branch from 2bce07d to 4f4edcb Compare March 5, 2021 15:54
@isidentical isidentical requested a review from martindurant March 5, 2021 16:13
@martindurant martindurant merged commit 2209529 into fsspec:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_ls_from_cache: weird behavior regarding comparisons with trailing slash
3 participants