Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/cached-aligner bugfix #1024

Open
wants to merge 1 commit into
base: feature/cached-aligner
Choose a base branch
from

Conversation

TimD1
Copy link

@TimD1 TimD1 commented Jan 30, 2025

This fixes most off-by-one errors, but there are still ArrayIndexOutOfBounds errors thrown every few hundred thousand alignments.

@TimD1 TimD1 requested review from nh13 and tfenne as code owners January 30, 2025 17:02
@TimD1 TimD1 temporarily deployed to github-actions January 30, 2025 17:02 — with GitHub Actions Inactive
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.51%. Comparing base (a44f400) to head (02ccad2).

Files with missing lines Patch % Lines
.../scala/com/fulcrumgenomics/alignment/Aligner.scala 66.66% 4 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/cached-aligner    #1024      +/-   ##
==========================================================
- Coverage                   95.59%   95.51%   -0.08%     
==========================================================
  Files                         126      126              
  Lines                        7722     7406     -316     
  Branches                      501      507       +6     
==========================================================
- Hits                         7382     7074     -308     
+ Misses                        340      332       -8     
Flag Coverage Δ
unittests 95.51% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant