Cross platform error codes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: updated Android side Initial upgrade with fix for listeners being duplicated
* master: Updated README for storage
Fix listenForAuth using incorrect base class methods
Facebook login fix android
Analytics parameter variable type fix for quantity, price and value.
Fix android exception
…tack * 'master' of github.com:fullstackreact/react-native-firestack: Parity of response format Parity of response format getToken(true) will try to fetch token from server and fail if offline. Analytics parameter variable type fix for quantity, price and value. fix missing downloadUrl property on ios fix missing downloadUrl property on ios
Add `invariant` dependency
Change to Fix breaking window object
Firebase.com is the legacy console. Firebase.google.com is the latest firebase console.
Readme link to firebase.google.com not firebase.com
Fix Storage on android
Don't hard set Android play services version #134
Added JS syntax highlighting
Maintain similar response format for getCurrentUser and signInWith*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly:
The current method for getting the Auth error code in Android is:
task.getException().hashCode()
this should be replaced with
task.getException().getErrorCode()
for greater error consistency between android and IOS.
Once that method is implemented we can create a function that takes the android and ios error codes and returns a universal error code which we can publish and developers can use to switch on for front end purposes e.g displaying an error message to a user.