Skip to content

Fix Storage on android #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Conversation

BlooJeans
Copy link
Contributor

No description provided.

@Salakar
Copy link
Collaborator

Salakar commented Nov 18, 2016

Implemented on my branch. (Just making a note)

@szujak
Copy link

szujak commented Nov 20, 2016

Omg, thanks for that pr. I was wondering why I get { message: 'User does not have permission to access this object.', code: 1 } all the time :( and this fix problem for me! 👍

@Salakar
Copy link
Collaborator

Salakar commented Nov 20, 2016

@szujak this is implemented on the v3 branch if you want to try it out

@szujak
Copy link

szujak commented Nov 20, 2016

@Salakar I got one problem with branch v3.

how to register something like this:
firestack.database().ref(user-data/${uid}/settings).on('value', this.onSettingsChange);
now it throws an error :(

FirestackDatabase.on got 4 arguments, expected 5
FirestackDatabase.on got 3 arguments, expected 4

is there a new way to register listeners?

@BlooJeans
Copy link
Contributor Author

BlooJeans commented Nov 22, 2016

@szujak The database error was solved in #154 , which is now merged into the v3 branch. If you can't / don't want to use v3 yet, then you can cherry pick the database fix from d50e976 (just remove react-native-firestack/lib/modules/database.js )

I'll keep this open until this is fixed in master (i.e. until v3 is merged into master)

Salakar added a commit to Salakar/react-native-firestack that referenced this pull request Nov 23, 2016
@auser auser merged commit 5f74060 into fullstackreact:master Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants