Skip to content

Handle OAuth2AccessTokenErrorResponse exception when attempting to parse access token. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle OAuth2AccessTokenErrorResponse exception when attempting to parse access token. #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e182a44
Handle OAuth2AccessTokenErrorResponse exception when attempting
mribbons Jul 31, 2017
a321a69
Further improve OAuth2AccessTokenErrorResponse exception handling
mribbons Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions android/src/main/java/io/fullstack/oauth/OAuthManagerFragmentController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import com.facebook.react.bridge.ReactContext;
import com.github.scribejava.core.exceptions.OAuthConnectionException;
import com.github.scribejava.core.model.OAuth2AccessTokenErrorResponse;
import com.github.scribejava.core.model.OAuth1AccessToken;
import com.github.scribejava.core.model.OAuth1RequestToken;
import com.github.scribejava.core.model.OAuth2AccessToken;
Expand Down Expand Up @@ -367,6 +368,11 @@ protected OAuth2AccessToken doInBackground(Void... params) {
Log.e(TAG, "OAuth connection exception: " + ex.getMessage());
ex.printStackTrace();
return null;
} catch (OAuth2AccessTokenErrorResponse ex)
{
Log.e(TAG, "Failed to extract access token: " + ex.getMessage());
mCtrl.onError(-1, ex.getMessage(), "Failed to extract access token.");
return null;
} catch (IOException ex) {
Log.e(TAG, "An exception occurred getRequestToken: " + ex.getMessage());
ex.printStackTrace();
Expand Down
12 changes: 12 additions & 0 deletions android/src/main/java/io/fullstack/oauth/OAuthManagerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,18 @@ public void onRequestTokenError(final Exception ex) {
Log.e(TAG, "Exception with request token: " + ex.getMessage());
_credentialsStore.delete(providerName);
_credentialsStore.commit();

WritableMap error = Arguments.createMap();
error.putString("message", ex.getMessage());

// In an invalid client situation we will get two errors, first for the invalid client, and second for the null access token
// we really want to report the invalid client error because it provides better feedback
try {
callback.invoke(error);
} catch (Exception e2)
{
Log.e(TAG, "exception with request: callback failed: " + e2.getMessage() );
}
}
public void onOAuth1AccessToken(final OAuth1AccessToken accessToken) {
_credentialsStore.store(providerName, accessToken);
Expand Down