Skip to content

Unbind events #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Unbind events #15

wants to merge 3 commits into from

Conversation

asafdav
Copy link

@asafdav asafdav commented Jan 18, 2015

Hi, thanks for this awesome lib.
I solved a memory leak you had (you didn't unregister the scroll and touch events).

@ghost
Copy link

ghost commented Jan 19, 2015

Thanks for the pull request! I'm getting a few javascript errors with this commit though. It looks like you may have copy pasted the bind logic from the parallax background attribute to the parallax attribute without changing out some values.

@asafdav
Copy link
Author

asafdav commented Feb 15, 2015

Hi, thanks for the review.
Let me know if it works better now.

@ghost
Copy link

ghost commented Feb 28, 2015

It looks like most of the correct directive values have been switched out, but I'm getting more errors while testing these changes. It looks like the parallax and parallaxBackground directives initially had a different attrs variable in the link function signature. I fixed the JS error by changing out the attrs variable with $attrs in the parallax directive, but that started throwing more errors in the unbind function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant