This repository was archived by the owner on Aug 16, 2024. It is now read-only.
Add permission and feature checking, improve is_admin#95
Open
AT0myks wants to merge 3 commits into
Open
Conversation
- make it return a boolean - use list comprehension instead of loop - it doesn't need to be async
and use it to detect PTZ support. I did not create this logic, just adapted it from pce.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permissions methods are unused for now, but will be in a future PR.
For the
is_adminchanges, theawaitwill need to be removed here.Also, I know that the logging in this method is here for Home Assistant, but ideally I think it should be moved to
reolink_dev(since it is the actual custom component andreolinkis the library it uses) andis_admincould then simplyreturn user["level"] == "admin".