Add support for widget.Form.Orientation property#11
Merged
Conversation
andydotxyz
requested changes
May 28, 2026
andydotxyz
left a comment
andydotxyz
left a comment
Member
There was a problem hiding this comment.
Nice thanks, just a couple of things
| if o := c.Metadata()[obj]["Orientation"]; o != "" && o != "Horizontal" { | ||
| switch o { | ||
| case "Vertical": | ||
| fmt.Fprintf(str, ", Orientation: %v", widget.Vertical) |
Member
There was a problem hiding this comment.
We should not print the number, but the developer friendly const.
I don't think this needs to be in a switch because you have ensured only these two could be set. Either that or the form code above could be simplified - I think this is duplicative
|
|
||
| return container.NewVBox( | ||
| &widget.Form{Items: []*widget.FormItem{widget.NewFormItem("Foo", | ||
| widget.NewEntry())}, OnSubmit: func() {}, OnCancel: func() {}, Orientation: 2}) |
Member
There was a problem hiding this comment.
We should test for more readable code - not the raw int but the const representation, i.e. widget.Vertical).
andydotxyz
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.