Refactor app/gui/queryresults/queryresultsservice.js
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add FIXME comments (eg. please "add function description") - code cleanup (eg. tons of weird ternary conditions, short-circuiting logic and missing brackets!) - full function rewrite `QueryResultsService::updateLayerResultFeatures(layer)` - notable function rewrite `QueryResultsService::_digestFeaturesForLayers (featuresForLayers)`
Raruto
commented
Feb 2, 2023
Raruto
changed the title
src/app/gui/queryresults/queryresultsservice.jsapp/gui/queryresults/queryresultsservice.js
Raruto
commented
Feb 3, 2023
Raruto
commented
Feb 3, 2023
Raruto
commented
Feb 3, 2023
Raruto
commented
Mar 29, 2023
# Conflicts: # package.json # src/app/gui/queryresults/queryresultsservice.js
…3w-suite/g3w-client into refactor-query-results-service # Conflicts: # src/app/gui/queryresults/queryresultsservice.js
…ex.prod.js as GUI method
- remove function `_digestFeaturesForLayers()` - rename function `_handleFeatureForLayer()` into `_responseToLayer()` - extract function `_hasLayerObjGeometry()` - extract function `_hasLayerObjImageField()` - refactor function `_parseLayerObjFormStructure()`
- remove nested if-else in: `getVectorLayerFeaturesFromQueryRequest()` - incorporate function `_addVectorLayersDataToQueryResponse()` into `*/ setQueryResponse()` setter - simplify destructuring assignment within `_printSingleAtlas()` function - remove function `_addComponent()`
…3w-suite/g3w-client into refactor-query-results-service
…apcontrol is active (undefined). Need to be set null to align default value and evaluation.
…yer is not add to query results state layers array
…onflict to download action to get all attributes of polygon query (query by polygon)
volterra79
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #452
List of changes:
@FIXMEcomments (eg. please"add function description"here)QueryResultsService::updateLayerResultFeatures(layer)QueryResultsService::downloadFeatures(type, layer, features=[], action, index)QueryResultsService::_addRemoveSelectionFeature(layer, feature, index, force)QueryResultsService::setActionsForLayers(layers, options = { add: false })QueryResultsService::_digestFeaturesForLayers(featuresForLayers)(replaced byQueryResultsService::setQueryResponse)QueryResultsService.prototype.downloadApplicationWrapper(downloadFnc, options)in favor ofGUI::downloadWrapper(downloadFnc, options)Closes: #58
Closes: #59
Preparatory for: #84
Related to: #193
NB this pull depends on #308 for the addition of the"util-deprecate"dependency (so it is recommended to merge the other one first to keep things tidy)