Skip to content

[26.1] Fix display bugs/usability of reports/pages - #23310

Open
ahmedhamidawan wants to merge 12 commits into
galaxyproject:release_26.1from
ahmedhamidawan:fix_markdown_rendering
Open

[26.1] Fix display bugs/usability of reports/pages#23310
ahmedhamidawan wants to merge 12 commits into
galaxyproject:release_26.1from
ahmedhamidawan:fix_markdown_rendering

Conversation

@ahmedhamidawan

@ahmedhamidawan ahmedhamidawan commented Aug 17, 2026

Copy link
Copy Markdown
Member

Items addressed here:

  • Some directives could have either history_dataset_id OR history_dataset_collection_id and we would error out when a directive for dataset display is used but collection ID is provided. This adds a reusable DatasetOrCollectionElement that accounts for that.
  • The item_url with slug like /u/{user_id}/d/{dataset_id}?preview=False never renders anything. This replaces a link to that with /datasets/${dataset_id}/display, which at least renders the entire dataset.
  • Space out the editor with the CellEditor in particular spanning more of the center panel width
  • Brings the add cell button inside of the previous cell to reduce whitespace
  • For directives that are collapsible, change the collapse to a nicely styled existing Heading component rather than a simple anchor

Overall Changes:

Before After
image image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan
ahmedhamidawan marked this pull request as ready for review August 20, 2026 17:48
@ahmedhamidawan
ahmedhamidawan requested a review from guerler August 20, 2026 18:29
@ahmedhamidawan ahmedhamidawan changed the title [26.1] [WIP] Fix display bugs/usability of reports/pages [26.1] Fix display bugs/usability of reports/pages Aug 20, 2026
@github-actions github-actions Bot added this to the 26.2 milestone Aug 20, 2026
@ahmedhamidawan

Copy link
Copy Markdown
Member Author
FAILED lib/galaxy_test/selenium/test_pages.py::TestPages::test_standalone_page_revision_diff - AssertionError

is passing locally and seems unrelated to the changes made here.

…rapper`

We had positioned "add a cell" option into a separate line. This merges that option into a button group with the expand cell button.
It makes more sense for a user that they can click that to edit the cell, rather than a collapse option which seems ambigious.
…pening

You'd need to click elsewhere to close the popper.
We were skipping rows because blank lines in a tabular file were being skipping as comment lines, and therefore we had count mismatch between the total rows and comment rows.
@ahmedhamidawan
ahmedhamidawan force-pushed the fix_markdown_rendering branch from b1a6cae to ec40b2d Compare August 21, 2026 21:51
@guerler

guerler commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
  1. Can you add vertical spacing to the icons inside these buttons:
image
  1. Also it seems that the containers are too wide which is why they are clipped:
image
  1. Suggesting to call it Insert Cell Below instead of Insert After for consistency with Insert Cell Above at the top.

  2. Looks like padding is missing at the end of the button label?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

2 participants