[26.1] Fix display bugs/usability of reports/pages - #23310
Open
ahmedhamidawan wants to merge 12 commits into
Open
[26.1] Fix display bugs/usability of reports/pages#23310ahmedhamidawan wants to merge 12 commits into
ahmedhamidawan wants to merge 12 commits into
Conversation
ahmedhamidawan
marked this pull request as ready for review
August 20, 2026 17:48
Member
Author
is passing locally and seems unrelated to the changes made here. |
…rapper` We had positioned "add a cell" option into a separate line. This merges that option into a button group with the expand cell button.
It makes more sense for a user that they can click that to edit the cell, rather than a collapse option which seems ambigious.
…pening You'd need to click elsewhere to close the popper.
We were skipping rows because blank lines in a tabular file were being skipping as comment lines, and therefore we had count mismatch between the total rows and comment rows.
ahmedhamidawan
force-pushed
the
fix_markdown_rendering
branch
from
August 21, 2026 21:51
b1a6cae to
ec40b2d
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Items addressed here:
history_dataset_idORhistory_dataset_collection_idand we would error out when a directive for dataset display is used but collection ID is provided. This adds a reusableDatasetOrCollectionElementthat accounts for that.item_urlwith slug like/u/{user_id}/d/{dataset_id}?preview=Falsenever renders anything. This replaces a link to that with/datasets/${dataset_id}/display, which at least renders the entire dataset.CellEditorin particular spanning more of the center panel widthHeadingcomponent rather than a simple anchorOverall Changes:
How to test the changes?
(Select all options that apply)
License