Skip to content

Updating workflows/amplicon/amplicon-mgnify/mgnify-amplicon-pipeline-v5-rrna-prediction from 0.2 to 0.3 - #1351

Open
RZ9082 wants to merge 2 commits into
galaxyproject:mainfrom
RZ9082:workflows/amplicon/amplicon-mgnify/mgnify-amplicon-pipeline-v5-rrna-prediction
Open

Updating workflows/amplicon/amplicon-mgnify/mgnify-amplicon-pipeline-v5-rrna-prediction from 0.2 to 0.3#1351
RZ9082 wants to merge 2 commits into
galaxyproject:mainfrom
RZ9082:workflows/amplicon/amplicon-mgnify/mgnify-amplicon-pipeline-v5-rrna-prediction

Conversation

@RZ9082

@RZ9082 RZ9082 commented Aug 24, 2026

Copy link
Copy Markdown
Member

FOR CONTRIBUTOR:

FOR REVIEWERS:

  • .dockstore.yml: file is present and aligned with creator metadata in workflow. ORCID identifiers are strongly encouraged in creator metadata. The .dockstore.yml file is required to run tests
  • Workflow is sufficiently generic to be used with lab data and does not hardcode sample names, reference data and can be run without reading an accompanying tutorial.
  • In workflow: annotation field contains short description of what the workflow does. Should start with This workflow does/runs/performs … xyz … to generate/analyze/etc …
  • In workflow: workflow inputs and outputs have human readable names (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless it is generally understood. Altering input or output labels requires adjusting these labels in the the workflow-tests.yml file as well
  • In workflow: name field should be human readable (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless generally understood
  • Workflow folder: prefer dash (-) over underscore (_), prefer all lowercase. Folder becomes repository in iwc-workflows organization and is included in TRS id
  • Readme explains what workflow does, what are valid inputs and what outputs users can expect. If a tutorial or other resources exist they can be linked. If a similar workflow exists in IWC readme should explain differences with existing workflow and when one might prefer one workflow over another
  • Changelog contains appropriate entries
  • Large files (> 100 KB) are uploaded to zenodo and location urls are used in test file

Closes #887

@RZ9082
RZ9082 requested a review from paulzierep as a code owner August 24, 2026 15:25

@SaimMomin12 SaimMomin12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small nit pick

"format-version": "0.1",
"license": "Apache-2.0",
"name": "MGnify's amplicon pipeline v5.0 - rRNA prediction",
"release": "0.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back release and assign 0.3

@RZ9082 RZ9082 Aug 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a while the release appears at the end. you can find it in line 3490.

@SaimMomin12
SaimMomin12 enabled auto-merge August 25, 2026 14:39
auto-merge was automatically disabled August 25, 2026 15:17

Pull request was closed

@SaimMomin12 SaimMomin12 reopened this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants