Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added question mark #5597

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Added question mark #5597

merged 4 commits into from
Feb 14, 2025

Conversation

MD-Chem
Copy link
Contributor

@MD-Chem MD-Chem commented Dec 4, 2024

Line 46 had a missing question mark

Line 46 had a missing question mark
@MD-Chem MD-Chem requested a review from a team as a code owner December 4, 2024 04:54
@@ -43,7 +43,7 @@ recordings:

Barcodes are small oligonucleotides that are inserted into the captured sequence at a specific point, and provide two pieces of information about the sequence:

1. Which cell the sequence came from
1. Which cell the sequence came from?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the sentence before it, maybe it should just be a period at the end of both items, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, if you want it to be a question, rephrase it "Which cell did the sequence come from?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shiltemann-agree with the latter point! Tbh, we were simply testing the system by making minor changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace - try committing the change on this branch to make both sentences questions! (Does that make sense? Select 'Files changed' above and you should be able to then Edit the file. Commit that change)
Then we can review and approve and you'll have experienced a true Github collaboration!

@shiltemann
Copy link
Member

thanks @MD-Chem!

shiltemann
shiltemann previously approved these changes Feb 14, 2025
Copy link
Member

@shiltemann shiltemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MD-Chem

@shiltemann shiltemann enabled auto-merge February 14, 2025 13:28
@shiltemann shiltemann merged commit 9feb7f0 into galaxyproject:main Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants