Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy training for the MFAssignR tool #5710

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

KristinaGomoryova
Copy link
Contributor

This is the PR for the MFAssignR tool, which allows multi-element molecular formula (MF) assignment for mass spectrometry. Individual parameters are explained as well as interpretation of the plots which are generated alongside. Several different sub-tools are used within the workflow (e.g. MFAssignR SNplot, etc.).

hechth
hechth previously approved these changes Jan 28, 2025
Copy link
Contributor

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tutorial, just few comments on language and few details but overall I think this is very instructive and easy to follow.

Copy link
Member

@shiltemann shiltemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KristinaGomoryova! Just a few technical/formatting suggestions below (you can hit the "commit suggestion" button to accept them)


@article{krevelen1950graphical,
title={Graphical-statistical method for the study of structure and reaction processes of coal.},
author={KREVELEN, VAN},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a DOI or url field to this entry

@shiltemann
Copy link
Member

@KristinaGomoryova I pushed a few technical changes to fix some of the linting errors, and it would be great if you could add test to your workflow (let us know if you need help with this)

I will leave final approval to @hechth since he is the expert on the topic, but from a technical point of view this is looking good 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants