Cross-Device Account Transfer (formerly Magic Link Auth)#1773
Draft
jmsv wants to merge 63 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gdorsi
reviewed
Apr 23, 2025
| const group = cojsonInternals.expectGroup(transferCore.getCurrentContent()); | ||
| const inviteSecret = group.createInvite("writer"); | ||
|
|
||
| return handlerUrl + `/${transfer.id}/${inviteSecret}`; |
Collaborator
There was a problem hiding this comment.
suggestion: how about throwing an error if the handlerUrl doesn't contain an hash?
Thinking about a way to enforce users to rely on the hash paths to reduce the expoure of the secrets
trishalim
approved these changes
Apr 29, 2025
…-simplify feat: unify handlerPath prop and rename hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #581
closes #1662
TODO:
MagicLinkAuthfunctionsjazz-tools,jazz-react-coreandjazz-react