SF Systems Nov 25 presentation#3130
Open
aeplay wants to merge 16 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| window?.location.hash.slice(1) === "" | ||
| ? 0 | ||
| : parseInt(window?.location.hash.slice(1)), | ||
| ); |
There was a problem hiding this comment.
Bug: Bug
The useState initialization accesses window.location.hash, which causes a TypeError during SSR or results in NaN for currentSlide, leading to hydration mismatches. The component also doesn't handle NaN from parseInt() for invalid hash values, which propagates to arithmetic operations in event handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual testing instructions
Tests
Checklist
Note
Adds an interactive SF Systems ’25 presentation (slides, diagrams, code samples), moves footer/search into docs/others layouts, and introduces the bs58 dependency.
app/(special)/presentations/sf-systems-25withSlides(arrow-key navigation),diagrams.tsx(CoValue core, hash/signature/encryption/group visuals),EffectiveTransactionsSlide,HashAndSignatureSlide,EditorIndicator, and MDX code snippets.JazzFooter/PagefindSearchfrom globalapp/layout.tsxand add them to(docs)/docs/[framework]/layout.tsxand(others)/layout.tsx.bs58for mock IDs/hashes/signatures.Written by Cursor Bugbot for commit 1d32773. This will update automatically on new commits. Configure here.