Add libwebsockets-dev dependency #4
Conversation
Signed-off-by: Ian Chen <[email protected]>
| @@ -81,6 +82,7 @@ Package: libgz-sim10-dev | |||
| Architecture: any | |||
| Section: libdevel | |||
| Depends: libtinyxml2-dev, | |||
| libwebsockets-dev, | |||
There was a problem hiding this comment.
Is it only being used in the development package? or should we expect to see it in runtime use cases even if no development tool is installed?
There was a problem hiding this comment.
hmm I copied from gz-launch which only adds it to the libgz-launch9-dev package. However, I am linking to websocket shared library in the websocket server system's CMakeLists.txt here. So I think I should add this to libgz-sim10-plugins right?
Added in f97c648. Let me know if that's not correct.
There was a problem hiding this comment.
hmm I copied from gz-launch which only adds it to the libgz-launch9-dev package. However, I am linking to websocket shared library in the websocket server system's CMakeLists.txt here. So I think I should add this to libgz-sim10-plugins right?
Ops sorry, I was not correct on the coment. The runtime dependencies should be handled by ${shlibs:Depends} in the binary runtime package so we should be covered and the gz-launch packaging is right.
Going to revert the last commit and merge since it was fine at the beginning. Sorry for the noise Ian.
There was a problem hiding this comment.
ah understood, thanks!
Signed-off-by: Ian Chen <[email protected]>
This reverts commit f97c648.
Related issue: gazebosim/gz-launch#288
Needed by: gazebosim/gz-sim#2792