Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling specific versions of its files via
git2
.Fixes #110 (by keeping the variable even after outliving its usefulness, so maybe not a real fix)
Paves the way for #117, since each lesson can now link to a commit in a repo, and possibly #17 also.
Motivation
.asm
files are now served “inline”, instead of via GitHub. (This is not strictly necessary, but I think it makes more sense.)Drawbacks
unbricked
is now a submodule, the associated submodule issues (git clone --recursive
,git archive
no longer working...) are brought in.unbricked
now requires PRing two separate repos (first the submodule, then this repo to update the commit being pointed at); and the former is not really a PR, since we need to keep one commit per lesson. OTOH it should reduce QA back-and-forth on PRs made to it.Notes
I expect that the
unbricked
repo would be moved to thegbdev
org before actually merging this.I also expect to perform the same modifications to Galactic Armada afterwards, if this is accepted.